codeforboston / maple

MAPLE makes it easy for anyone to view and submit testimony to the Massachusetts Legislature about the bills that will shape our future.
https://mapletestimony.org
MIT License
44 stars 118 forks source link

add hshareef9 as a contributor for code #1212

Closed allcontributors[bot] closed 1 year ago

allcontributors[bot] commented 1 year ago

Adds @hshareef9 as a contributor for code.

This was requested by hshareef9 in this comment

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2023 2:28am
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **maple-prod** | ⬜️ Ignored ([Inspect](https://vercel.com/maple-testimony/maple-prod/PzVnbmLxhjZBBq5DtU1HkRvZVDDd)) | | | Jul 9, 2023 2:28am |
tommagnusson commented 1 year ago

@hshareef9 looks like the formatting check failed. Would you mind running

npm run fix
saltair3 commented 1 year ago

@tommagnusson where am I supposed to run that command?

tommagnusson commented 1 year ago

@tommagnusson where am I supposed to run that command?

In your terminal in the root of the project, just like when you're running the local version of the site.

saltair3 commented 1 year ago

@tommagnusson not sure how that would work maple has yarn I went ahead and ran that command and it didn't work I didn't push code from my terminal, it's from #1211

tommagnusson commented 1 year ago

@tommagnusson not sure how that would work maple has yarn I went ahead and ran that command and it didn't work I didn't push code from my terminal, it's from #1211

Oops I didn't realize the bot was creating the MR. Ultimately, the bot isn't applying the correct formatting in its automatically generated PR, which is why the pipeline is failing.

The bot only supports a very specific syntax in GitHub issues... I was assuming you were running the command in the terminal in your normal coding environment.

Some potential fixes:

Maybe we can discuss tomorrow.