codeforboston / maple

MAPLE makes it easy for anyone to view and submit testimony to the Massachusetts Legislature about the bills that will shape our future.
https://mapletestimony.org
MIT License
44 stars 118 forks source link

1208 make settings a hyperlink on profile page #1246

Closed gerlinp closed 1 year ago

gerlinp commented 1 year ago

Summary

Due to the 'Make public/private' button already in place, changing the wording of the message to reflect the page properly.

Screenshots

image

Steps to test/reproduce

  1. If not logged in, Login to your account.
  2. Click on your account name at the top right and click on view profile.
  3. Make your account public and/or private to confirm changes are correct on both.
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ❌ Failed (Inspect) Oct 5, 2023 3:27am
vercel[bot] commented 1 year ago

@gerlinp is attempting to deploy a commit to the Maple Testimony Team on Vercel.

A member of the Team first needs to authorize it.

mvictor55 commented 1 year ago

Hi @gerlinp - we have reviewed this and it needs adjustments due to conflicts. Are you free next Tuesday to discuss at the meeting?

saltair3 commented 1 year ago

Hey @gerlinp Thanks for your efforts. I looked at your contributions. They look great! When looking at the files changed I noticed a NewsFeedCard and svg. This is coming in from previous commits labeled newsfeed. Also, in the commit history it looks like there was an attempt to merge your branch into main. I'm thinking what you intended to do is pull from main to update the branch but accidentally did it the other way around. Pulling from main should update the branch and remove the outdated newsfeed files! Other than that, the code works as intended and I'm happy to approve the pr after that small change! :)

saltair3 commented 1 year ago

@mvictor55 Just saw your comment! I just reviewed the PR yesterday. Please see my comments above. Thanks!

gerlinp commented 1 year ago

Sorry Just seeing this, Was on vacation this past week, but thank you @hshareef9

saltair3 commented 1 year ago

Hey @gerlinp, Just checking in... :)