Closed oherma01 closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
maple-dev | ❌ Failed (Inspect) | Aug 30, 2023 1:29pm |
@oherma01 is attempting to deploy a commit to the Maple Testimony Team on Vercel.
A member of the Team first needs to authorize it.
Everything is good to go! Storybook after build seems to be upset with a type differential but is negligible. very good looks with the dynamic filtered results of the newsfeed. Also, great catch with the clean up. I know you are implementing a quick fix for another issue and will approve this for merge when that code is in.
Everything is good to go! Storybook after build seems to be upset with a type differential but is negligible. very good looks with the dynamic filtered results of the newsfeed. Also, great catch with the clean up. I know you are implementing a quick fix for another issue and will approve this for merge when that code is in.
Thanks Mark! Just added the quick fix for the org profile link now.
Party on!!!
On Wed, Aug 30, 2023 at 9:31 AM Oliver Herman @.***> wrote:
Everything is good to go! Storybook after build seems to be upset with a type differential but is negligible. very good looks with the dynamic filtered results of the newsfeed. Also, great catch with the clean up. I know you are implementing a quick fix for another issue and will approve this for merge when that code is in.
Thanks Mark! Just added the quick fix for the org profile link now.
— Reply to this email directly, view it on GitHub https://github.com/codeforboston/maple/pull/1266#issuecomment-1699182329, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARANGSETKVJCBPW4TFJE7WDXX46BNANCNFSM6AAAAAA4DVZJMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Summary
Checklist
Screenshots
Add some screenshots highlighting your changes.
Before:
After:
Known issues
Will want to implement pagination, for some number of notifications, and probably have it be different on mobile vs desktop
I am leaving this PR as a draft, as #1203 should be merged to dev first.