codeforboston / maple

MAPLE makes it easy for anyone to view and submit testimony to the Massachusetts Legislature about the bills that will shape our future.

https://mapletestimony.org

MIT License

44 stars 118 forks source link

faq functionality #1284

Closed saltair3 closed 1 year ago

saltair3 commented 1 year ago

Summary

1271

figma: https://www.figma.com/file/pGGIX2tmCWJNGU1sAYQ91v/FAQ?type=design&node-id=4001-29831&mode=design&t=5BYPwvKnYrgb4LUY-0

ABOUT page that includes collapse functionality - click on questions to see answers displayed
Json to store Faq content for parsing - md docs limited parsing
Accordion did not provide flexibility for needed modifications- used Bootstrap Collapse
Dropdown feature is future version and is not included

Checklist

[ ] On the frontend, I've made my strings translate-able.
[ ] If I've added shared components, I've added a storybook story.
[ X ] I've made pages responsive and look good on mobile.

Screenshots

Desktop View:

https://github.com/codeforboston/maple/assets/101157878/37a363e3-d846-48d4-8279-6ecd3f5a487e

Mobile View:

https://github.com/codeforboston/maple/assets/101157878/132db782-8889-4cdb-8d27-9d61ab03b465

Known issues

n/a

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
maple-dev	❌ Failed (Inspect)			Sep 8, 2023 4:26pm

vercel[bot] commented 1 year ago

@hshareef9 is attempting to deploy a commit to the Maple Testimony Team on Vercel.

A member of the Team first needs to authorize it.

jamesvas5307 commented 1 year ago

Looks mainly good, two notes on the design side:

We should have a horizontal rule under each header like the one at the top.
The FAQ questions were supposed to be accordions than you can toggle on and off (MVP version as well as the one with the sort dropdown)

saltair3 commented 1 year ago

@ jamesvas5307

Can you please clarify where you see absent horizontal rulers? I have put horizontal rulers under every heading. (Please see screen recording)

From dev side, UX requirements cannot be coded with accordions. The UX requirements resemble more of a Card with collapse features which is what I did.

jamesvas5307 commented 1 year ago

Oh sorry! I didnt even the video of it! I went on the dev and saw FAQ there and assumed that was it. My bad!

The video looks great!

saltair3 commented 1 year ago

@jamesvas5307

LOL no worries, I added a vid for the mobile view as well!

mertbagt commented 1 year ago

good to go! :rocket: