codeforboston / maple

MAPLE makes it easy for anyone to view and submit testimony to the Massachusetts Legislature about the bills that will shape our future.
https://mapletestimony.org
MIT License
44 stars 118 forks source link

Update "Our Team" page #1362

Closed hanboyu closed 1 year ago

hanboyu commented 1 year ago

Summary

Closes #1353

Updated "Our Team" page according to the Figma design: https://www.figma.com/file/vH0gBrC6f6VctocGNhhWSD/Teams-Page?type=design&node-id=301-2112&mode=design&t=Tt9T6EDbk437f5v3-0

Checklist

Screenshots

Desktop View:

screencapture-localhost-3000-about-our-team-2023-10-26-15_32_12 screencapture-localhost-3000-about-our-team-2023-10-26-15_32_47 screencapture-localhost-3000-about-our-team-2023-10-26-15_33_01

Mobile View:

screencapture-localhost-3000-about-our-team-2023-10-26-15_33_31 screencapture-localhost-3000-about-our-team-2023-10-26-15_33_59 screencapture-localhost-3000-about-our-team-2023-10-26-15_34_28 image

Steps to test/reproduce

  1. Go to the home page
  2. Click "About" -> "Our Team" in the menu
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 8:52pm
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **maple-prod** | ⬜️ Ignored ([Inspect](https://vercel.com/maple-testimony/maple-prod/7cRm9xsidKdfLTUwji7CZow69RnN)) | [Visit Preview](https://maple-prod-git-fork-hanboyu-update-our-t-8002d9-maple-testimony.vercel.app) | | Oct 26, 2023 8:52pm |
mvictor55 commented 1 year ago

@hanboyu looks great!! One comment -- we forgot to change the description for the Advisory Board. Can you update it to reflect this:

image

I've also updated the figma desktop version

nesanders commented 1 year ago

Looking good! Thank you @hanboyu

A few questions, partly for @mvictor55

mvictor55 commented 1 year ago

I think we should try to hyperlink our own emails. But, for now, don’t need to adjust the links in our advisors’ profiles

On Thu, Oct 26, 2023 at 4:07 PM Nathan E. Sanders @.***> wrote:

Looking good! Thank you @hanboyu https://github.com/hanboyu

A few questions, partly for @mvictor55 https://github.com/mvictor55

  • Do we want to hyperlink (mailto) the email addresses?
  • Do we want to hyperlink to any of our team/advisor's homepages or to the websites of their affiliated orgs? Not sure if the original bios we collected had links or not.

— Reply to this email directly, view it on GitHub https://github.com/codeforboston/maple/pull/1362#issuecomment-1781823919, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARANGSCHSHQ75SYXI7TLEV3YBK7HFAVCNFSM6AAAAAA6RXPARCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBRHAZDGOJRHE . You are receiving this because you were mentioned.Message ID: @.***>

hanboyu commented 1 year ago

@hanboyu looks great!! One comment -- we forgot to change the description for the Advisory Board. Can you update it to reflect this: image

I've also updated the figma desktop version

Opps, I just fixed it.

hanboyu commented 1 year ago

I think we should try to hyperlink our own emails. But, for now, don’t need to adjust the links in our advisors’ profiles On Thu, Oct 26, 2023 at 4:07 PM Nathan E. Sanders @.> wrote: Looking good! Thank you @hanboyu https://github.com/hanboyu A few questions, partly for @mvictor55 https://github.com/mvictor55 - Do we want to hyperlink (mailto) the email addresses? - Do we want to hyperlink to any of our team/advisor's homepages or to the websites of their affiliated orgs? Not sure if the original bios we collected had links or not. — Reply to this email directly, view it on GitHub <#1362 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARANGSCHSHQ75SYXI7TLEV3YBK7HFAVCNFSM6AAAAAA6RXPARCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBRHAZDGOJRHE . You are receiving this because you were mentioned.Message ID: @.>

Currently, the emails in "Steering Committee" are not hyperlinked, I can quickly change that.

mertbagt commented 1 year ago

:rocket: