search

codeforboston / maple

MAPLE makes it easy for anyone to view and submit testimony to the Massachusetts Legislature about the bills that will shape our future.
https://mapletestimony.org
MIT License
44 stars 118 forks source link

bootstrap refactoring #1439

Closed azheng1991 closed 6 months ago

azheng1991 commented 8 months ago

Summary

Add a short summary of the changes, and a reference to the original issue using # and the issue number, like #1 REFACTOR: About Pages #1417 -converted files to tsx -incorporated bootstrap in SupportMapleCardContent -removed css file for SupportMapleCardContent

Screenshots

image

Steps to test/reproduce

  1. Click on about
  2. Select "How to Support Maple"
  3. See that component loads fine with bootstrap modifications

@all-contributors please add @azheng1991 for refactoring contributions

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ❌ Failed (Inspect) Feb 21, 2024 5:10pm
azheng1991 commented 8 months ago

@sashamaryl deleted all js and css files, all tsx files use bootstrap, could you clarify on the component re-use again? Based on the code I'm seeing, a lot of the components being used seem to be customized (e.g. within the ForIndividualsCardContent component, you have customized components like WhyMapleCardContent and BenefitsCardContent). Since the components are different as per each card, wasn't sure where to start

Mephistic commented 6 months ago

Thanks for the PR! This is no longer needed - we've finished the migration for these components. Going to close this.