codeforboston / maple

MAPLE makes it easy for anyone to view and submit testimony to the Massachusetts Legislature about the bills that will shape our future.
https://mapletestimony.org
MIT License
44 stars 118 forks source link

Bootstrap Migration for Twitter #1459

Closed Mephistic closed 7 months ago

Mephistic commented 8 months ago

NOTE: This is a Twitter timeline embed that doesn't seem to be used anywhere - someone with a better grasp of the project's history should confirm whether we want to re-enable this. If not, this issue could be simplified to just delete the component.

This issue is meant to track the remaining work needed to close out the migration from css modules to react-bootstrap/styled components/typescript. This issue covers the Twitter component.

Success Criteria:

This card just covers this work for the Twitter component

Mephistic commented 8 months ago

UPDATE: We should be safe to just kill this off. It's not used, years old, and even if we decide we want to bring it back later, this is just a thin wrapper around a twitter timeline embed library - easy enough to reimplement.

mvictor55 commented 8 months ago

@Mephistic if this is just a timeline embed (ie. we probably envisioned embedding the MAPLE twitter feed on the site) -- then agreed, we can scrap. At one point, we had created a function where: after a user submits testimony, a modal/button appears that asks if they'd like to share their testimony on twitter. If they click "yes", then their twitter is opened with a preloaded tweet containing text, something like, "I just shared testimony on MAPLE - check it out here: [link]". I think we do want to bring that feature back -- so just want to make sure that this component is for the embed, and not for the external tweet feature.

Mephistic commented 8 months ago

@mvictor55 Yup, this is just the unused Twitter timeline embed (for the account GGovernanceProj). All other Twitter-related links/functionality should be unaffected by this card.

mvictor55 commented 7 months ago

@Mephistic sounds good!