codeforboston / maple

MAPLE makes it easy for anyone to view and submit testimony to the Massachusetts Legislature about the bills that will shape our future.
https://mapletestimony.org
MIT License
44 stars 118 forks source link

Fix Testimony Details Link #1476

Closed Mephistic closed 7 months ago

Mephistic commented 8 months ago

Problem

After the most recent production deploy, we've started seeing links on the site fail to work. When we click one of these links, nothing happens and we see a console error: Error: Loading initial props cancelled, and what seems to be an infinite loop of GET requests. So far, it looks like this is happening with all links to a Testimony detail page. I can't seem to reproduce the bug in local development, though we see it in both the deployed dev and production environments.

Places we've seen this happen:

Interestingly, if you right click and open the page in a new tab, the link loads correctly in that tab.

Repro Steps

  1. Go to the page for a specific bill (e.g. https://www.mapletestimony.org/bills/193/S2555)
  2. Click the More Details on a Testimony in the Testimonies section
  3. See that nothing happens except for the aforementioned console error

Alternatively:

  1. Go to the List Testimonies page
  2. Click on any testimony

Success Criteria

@mvictor55

mvictor55 commented 8 months ago

To add one more spot this bug manifests: on the homepage, in the "what people are saying..." boxes (see screenshot below). Seems pretty clear that any link to a "detailed testimony" page is having this issue.

image