codeforboston / maple

MAPLE makes it easy for anyone to view and submit testimony to the Massachusetts Legislature about the bills that will shape our future.

https://mapletestimony.org

MIT License

44 stars 118 forks source link

Update Key Prop for Calendar Event #1484

Closed Mephistic closed 8 months ago

Mephistic commented 8 months ago

Summary

Just saw a duplicate key error in the HearingsScheduled carousel when poking around the site locally. It looks like we're just using the id of the underlying event for the key, but we have different types of events pulled from different sources that can (and in at least one case this month, did) have the same key. Adding type to the key here should guarantee the key's uniqueness going forward.

Checklist

[na] On the frontend, I've made my strings translate-able.
[na] If I've added shared components, I've added a storybook story.
[na] I've made pages responsive and look good on mobile.

Screenshots

N/A

Known issues

N/A

Steps to test/reproduce

Go to the home page
Open the browser console
See that there are no warnings about

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
maple-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 2, 2024 9:15pm