Privacy Setting - Adjusting "Browse Testimony"

[kiminkim724]

Summary

Closes #1431 On Browse Testimony:

• Move the "Author" filter to the top of the filters
• Remove any user who has designated themselves as "private" from the "Author" filter
  • This is done by setting the authorDisplayName as "private" and then using transformitems on the RefinementList to filter the private users out of the RefinementList.
• For any "private user", their name should not be hyperlinked/clickable
• All users should have their full name shown

Checklist

• [ ] On the frontend, I've made my strings translate-able.
• [ ] If I've added shared components, I've added a storybook story.
• [ ] I've made pages responsive and look good on mobile.

Screenshots

Jeff as a public user:

Jeff as a private user:

Known issues

• Since we use transformitems to filter out "private" from the RefinementList, on the off chance that a user signs up with a name as "private" it'll always filter them out of the list, no matter what their privacy status is.

Steps to test/reproduce

For each feature or bug fix, create a step by step list for how a reviewer can test it out. E.g.:

1. Go to Browse Testimony and check if private users have their names filtered from the Author List
2. Go to profile and change privacy status to see if the hyperlinks and names appear in the Author list and Testimony results.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
maple-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 27, 2024 0:34am

[mvictor55]

hmm @kiminkim724 i'm not able to reproduce without a few bugs (maybe a result of the preview environment)

• All names appear as black text (not hyperlinked, regardless of privacy setting). I was able to click into Boyu's profile (see screenshot below)
• The private users seem to have their names blanked (see screenshot below). When I click on their testimony - it gives me a 404.

Maybe you need to repull from dev and incorporate changes?

[mertbagt]

can you comment on this PR what the Integration Test issues are so we can get that looked at?

[kiminkim724]

can you comment on this PR what the Integration Test issues are so we can get that looked at?

It's the publishTestimony tests under tests/integration/testimony.test.ts.

[kiminkim724]

hmm @kiminkim724 i'm not able to reproduce without a few bugs (maybe a result of the preview environment)

• All names appear as black text (not hyperlinked, regardless of privacy setting). I was able to click into Boyu's profile (see screenshot below)

I think this is mainly because there are some back-end changes to the PR, that requires to be merged into the dev environment to correctly add the "private" field to the testimony, which is what's checked for a user to be hyperlinked or not.

• The private users seem to have their names blanked (see screenshot below). When I click on their testimony - it gives me a 404.

This is, unfortunately, the result of what happened with my script overriding the values in the older testimonies, so the testimonies before I think it was the end of November don't have information in Firebase, so we're unable to access the detailed view of those testimonies.