search

codeforboston / maple

MAPLE makes it easy for anyone to view and submit testimony to the Massachusetts Legislature about the bills that will shape our future.
https://mapletestimony.org
MIT License
38 stars 106 forks source link

[1508] Add Playwright for e2e testing #1535

Closed seatuna closed 1 week ago

seatuna commented 1 month ago

Summary

Issue: https://github.com/codeforboston/maple/issues/1508

This PR adds Playwright for e2e testing, a simple test for the MAPLE homepage, and resolves peer dependency issues related to testing and i18n packages. The following packages were upgraded:

Known issues

Updating jest to v29 introduced an error related to ESM imports for integration tests that touch firebase. To fix this, I had to add a custom resolver per this github thread: https://github.com/microsoft/accessibility-insights-web/pull/5421#issuecomment-1109168149

I don't have firebase set up, so I couldn't check to make sure that the tests are actually passing. I just made sure that it was in the same state as when I ran the tests in the main branch. Someone with firebase set up should absolutely run the integration tests to make sure they're behaving as expected.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ❌ Failed (Inspect) Apr 30, 2024 7:53pm
seatuna commented 1 week ago

Closing this PR, I redid it here: https://github.com/codeforboston/maple/pull/1554