Create graded color function for the districts

codeforboston / maple

MAPLE makes it easy for anyone to view and submit testimony to the Massachusetts Legislature about the bills that will shape our future.

https://mapletestimony.org

MIT License

44 stars 118 forks source link

Create graded color function for the districts #43

Closed mvictor55 closed 3 years ago

mvictor55 commented 3 years ago

4 tiers

Green: Legislator is on record "I will vote for this if it's introduced as a standalone bill"
Light green: Legislator has been a substantial advocate for this bill in the past
Lighter green: Legislator has advocated for this bill in the past
Grey: Legislator has not advocated for this bill in the past

pgibb96 commented 3 years ago

Will this override the current color scheme of blue/red:democrat/republican, or is it just on the pop up when you click on a district?

bhrutledge commented 3 years ago

@pgibb96 Good question. Pretty sure it's the former, i.e. replacing the current color scheme, which I just added as a placeholder/example.

mvictor55 commented 3 years ago

@pgibb96 @bhrutledge yes the former. So we can copy and augment what Brian did for the new colors and associated grading?

mvictor55 commented 3 years ago

@bhrutledge I added a column to the EDR Data sheet (column y) that indicates the "points" per legislator. Column Z converts these points to grades in the following manner: 0 points = grade 4 1-2 points = grade 3 3+ points = grade 2 On record commitment = grade 1 (note: we don't have any on record commitments yet)

I could delete the "points" column, since it's only relevant for calculations. Just let me know. Also @d-ondrich and @mikewheel said they could take a stab at this if you're busy this week.

bhrutledge commented 3 years ago

Thanks, @mvictor55. I'm aiming to take a look, and hopefully get it wired up (at least initially) ~~via #37~~.

mvictor55 commented 3 years ago

@bhrutledge Thanks! Let me know if you need me to clean anything up or anything to make it easier

bhrutledge commented 3 years ago

@mvictor55, before I close this, can you respond to the comments I made in the EDR Data sheet? Specifically:

It looks like the colors in the bill columns are manually applied. For the Act On Mass sheet, I was to able to accomplish that with Conditinal Formatting. I think I could do that quickly here.
It looks like the points and grade columns were calculated manually. I think it would be better to use a formula. I can probably take a pass at that.

bhrutledge commented 3 years ago

Initial work is done; follow-up will be handled by other issues