codeforboston / maple

MAPLE makes it easy for anyone to view and submit testimony to the Massachusetts Legislature about the bills that will shape our future.
https://mapletestimony.org
MIT License
44 stars 118 forks source link

Bill Detail Testimony View - Testimony Table #885

Closed alexjball closed 1 year ago

alexjball commented 1 year ago

Figma mocks: https://www.figma.com/file/Uyh2NXGTCX60mkse2NVBH7/MAPLE?node-id=2082%3A15369&t=ttcSvKA5UgxM1AMr-4

mvictor55 commented 1 year ago

@MarkTrepanier can you share an update on this?

mvictor55 commented 1 year ago

My guess is that we've finished the critical parts, but maybe haven't sync'd with typesense?

MarkTrepanier commented 1 year ago

Correct, most of the critical behavior is complete. A compromise on pagination and design had to be made based on the current pagination we are using that does not allow a specific page to be set. Beyond that, for the hooks to work correctly, that filter the individuals and organizations, indexes need to be added to the firestore. They can be added automatically, with a link provided in the console during an attempt to use the hook, but this index is removed when the backend is updated

mvictor55 commented 1 year ago

Revisiting -- All that is left is indexing the firestore DB -- and then tweaking the front end?

MarkTrepanier commented 1 year ago

The backend tweak seems to have already been completed. I can fix the Our Testimonies type today as well today. It turns out not to be a typo as pointed out by Tim, but instead a conditional bug that should be set to whether or not the user is an Organization but is instead set to always true

tommagnusson commented 1 year ago

This is already done