codeforboston / pantry_pickup

Combining city data with a list of specific needs from food pantries will allow citizens to most effectively make useful and needed donations assisted by the Pantry Pick-Up App.
http://www.pantrypickup.org
21 stars 35 forks source link

Remove radius boundary from search. #22

Closed ohnorobo closed 11 years ago

ohnorobo commented 11 years ago

Since we only have ~300 data points there's no real speed improvement for returning a subset of points, and returning all the points is not confusing to the user. If someone tries to access the site from outside the GBA they're going to see a map with no points even if they zoom out. The radius selector also takes up valuable space in the search bar.

Discuss?

carpeliam commented 11 years ago

Ultimately the search will definitely have to be redesigned, but I feel like we'll be doing as much (if not more) adding as we will be removing, either based on current hours or particular food needs, etc. Maybe we'll need to have both a basic search and an advanced search? Not sure, but I think it's too early to say.

At the moment, all results are returned upon an initial page load, and only subsequent requests include limits... I'm not sure to be honest if it's confusing to get a large number of results or if there's a performance issue, as I'm guessing target users will have slower computers or may be using phones.[1] As far as handling users outside of the GBA is concerned, I think that's a good question and worth considering separately- even if we show all of the results (which we do, initially), Pantry Pickup only serves the communities that contain data, so if your location doesn't have any data, your default map view won't have any breads.

Also, while we only have ~300 data points at the moment, there's nothing about Pantry Pickup that is built to only serve the GBA community- this can be ported to other communities of varying size, and shouldn't be at all restrictive or make assumptions.

I'd recommend leaving the radius in for now, at least until we're able to implement a more comprehensive/useful search, and move the discussion regarding what should be part of search over to #5.

[1] Great paper discussing how client-side activity affects mobile battery life: http://www2012.wwwconference.org/proceedings/proceedings/p41.pdf