slight cleanup; warning on Mongo connection failure

codeforboston / pantry_pickup

Combining city data with a list of specific needs from food pantries will allow citizens to most effectively make useful and needed donations assisted by the Pantry Pick-Up App.

http://www.pantrypickup.org

21 stars 35 forks source link

slight cleanup; warning on Mongo connection failure #25

Closed rlaskey closed 11 years ago

rlaskey commented 11 years ago

Nothing crazy, but functionally we at least get an error message if the connection to MongoDB doesn't work. I also have a temporary variable dev for whether we're in development, to simplify some of the logging options, etc.

carpeliam commented 11 years ago

error messages are great! I'll review this soon, there are a few things I might want to change before I pull it in- e.g., there's already an environment variable for NODE_ENV, and I'd like to squash some of these commits before merging them into master (are you familiar with squashing?).

rlaskey commented 11 years ago

Cool, squash away!

I have a number of other commits after that one, in my branch.

The extra variable is just for compactness -- we want to test for being in dev in a number of places in that file, and the ordering is presumably for speed and precedence, so I didn't want to lump everything in one place.

Other commits add some cosmetics to the info bar, and tidies up the template to be fully Jade rather than a mix.

I also have some work that I have not yet committed, which we can discuss tomorrow. I tied into some events for moving around and zooming in the map which greatly reduces the number of objects on hand. Even on my desktop it seems to run faster.

rlaskey commented 11 years ago

Hm, I looked into squashing a bit more. I understand the desire to compact history, but do you know what it'll do to the branches? Since I pushed all of these commits to my repository, it seems like a rebase may disconnect these a bit ? Not sure what the standard GitHub practice is, but I'm thinking that more commits for the benefit of keeping a consistent history may be worth it. Thoughts?