search

codeforboston / pantry_pickup

Combining city data with a list of specific needs from food pantries will allow citizens to most effectively make useful and needed donations assisted by the Pantry Pick-Up App.
http://www.pantrypickup.org
21 stars 35 forks source link

Moving the map erases user's selection #27

Closed carpeliam closed 11 years ago

carpeliam commented 11 years ago

If I've chosen a pantry, and I move the map in any way (zoom in/out, or pan in any direction), a new search is executed, and the user's selection is removed. This seems to have been introduced in 667bbcc3c595ea9f2c4cc2865665bd4b5bb373dc.

rlaskey commented 11 years ago

Yep, that's intentional. We are searching around the bounds of the visible map. If those parameters change, then the previous search should definitely be invalidated.

For example, if you move the map to the right slightly, the previous search would not necessarily find the pantries on what's now the left edge, previously off screen to the far west.

If you want details on a pantry, it will show up in the info panel. If you are moving the map, closing out that info panel also has the benefit of showing you more of the map at that time. As it was previously, the info panel was also hiding any pantries to the east of the previously selected pantry.

carpeliam commented 11 years ago

I'd argue this doesn't follow the principle of least surprise. If I click on a location on the map but then choose to zoom in on it, I shouldn't have my selection removed. Once I've chosen a pantry and I want to know more about the area, I shouldn't have to reselect the same pantry repeatedly every time I move the map.

ohnorobo commented 11 years ago

This also causes unusual looking close-open behavior in the side panel if you select two pantries in succession. I agree that the behavior was surprising, but Liam and I have also been working with the current behavior for a while. Maybe we should find someone unbiased and do a micro usability test?