Closed bdougsand closed 8 years ago
I think this is looking great, and indeed a pretty beastly PR. I'm all for merging this back into master, so long as we turn your notes into issues moving forward (i.e assumptions in: 9ebb5f249cc76f7743025e76bfda9b242b61901c) so they don't get lost. Thanks & sorry for the monumental delay, this was getting dusty!
I don't know enough about docker to make any technical comments, but I think that a dockerized approach to deployment sounds better than the faux-Capistrano approach we had previously, as far as I know. Very cool!
I couldn't really tell from (very quickly) looking through the changes if the db dump exported/copied an actual mongo dump, or if it just runs the pantry_import
python script within the container as part of the install.
For now, the app still runs pantry_import.py at startup.
As you noticed, I was considering importing from a db dump. But there's a better alternative. It's possible with Docker to take a snapshot of a running container to create an image that can then be shared on a registry (e.g., DockerHub). So, in the development environment, we could simply start from a pre-populated mongo image.
See commit messages for additional details. (Pardon the monolithic pull request!)