codeforboston / urban-league-heat-pump-accelerator

Urban League Heat Pump Accelerator Project
MIT License
33 stars 22 forks source link

Ensure homes from initial load are canonicalized #498

Open mikelynch opened 11 months ago

mikelynch commented 11 months ago

For the address canonicalization logic to work and properly detect collisions with newly created homes (e.g. by public survey users), we need to ensure all addresses from the initial data load are canonicalized. This should already be happening automatically (we have an after_save trigger that calls the canonicalization logic), and we call home.save! (see code).

We should verify the homes table after initializing it with the latest CanonicalizeAddressJob changes to verify what values the status column has. If we see canonicalized for all of them, then that's fine. If we're still seeing unrecognized values, then we need to check why – it's possibly another Pelias issue. To get a useful answer on this, we probably need to make sure we're using the latest version of Pelias (we know the address lookups will currently fail).

mzagaja commented 2 weeks ago

Findings from discovery today:

Next week: Write rake task to go through and canonicalize the existing seed data. Then we will export it as a CSV in the format we have and update it.