codeforboston / windfall-elimination

Windfall Elimination Provision Awareness Project: improving the experience of retirees around an obscure Social Security rule affecting 8+ states (previously https://ssacalculator.org)
https://windfall-develop.netlify.app/
MIT License
24 stars 45 forks source link

Issue #234: add SHOW_FUTURE_EARNINGS_PAGE env var #235

Closed ethanstrominger closed 3 years ago

ethanstrominger commented 4 years ago

Co-authored-by: dmeegan dn_meegan@yahoo.com Co-authored-by: Matan Kotler-Berkowitz 205matan@gmail.com

thadk commented 3 years ago

Hi @ethanstrominger did you set up a netlify site for this variable yet?

thadk commented 3 years ago

Because #236 has a change that temporarily breaks the line8line40 branch by removing the automatic minimum and maximum earnings year determinations for the detailed calculator. #233 almost already fixes by re-adding them at a higher level to the src/library/pia/index.ts AnyPIA-js wrapper, but it needs a fix on https://github.com/codeforboston/windfall-elimination/commit/b1d583df4a3263c0bf8a6ea00db9878891eba330#diff-c0920b50518efcd68fac7ddfdb01f6a9a18ddbed635af44f0fc8a65f27971affR75

It seems there is no harm in delaying this until we:

thadk commented 3 years ago

I think we've fixed #236 but introduced another change we should handle at the next hacknight: https://github.com/codeforboston/windfall-elimination/commit/93990a92d6410e796d802ae72196c19898c5a3b5