search

codeforbtv / baby-equipment-exchange

MIT License
0 stars 8 forks source link

containerized development environment in a docker so that it's most consistent and onboarding is easier #49

Closed abdullahalhoothy closed 8 months ago

mattlindsey commented 8 months ago

Hi. Small comment. You may want to call README_old.MD something else, like README_local_setup.MD. Or put the local setup instructions somewhere else since not everyone may want to use Docker. :)

abdullahalhoothy commented 8 months ago

Thanks matt, the goal is not to make it complicated and i understand some don't want to work with docker. for the time being i added the local development method to the same readme. i will delete the old readme , i forgot about it

mattlindsey commented 8 months ago

Goal sounds good Abdullah, although I'm a little worried that if this PR is merged the instructions won't contain some useful information for 'local' developers, which I think you deleted. If I'm wrong and they are somewhere, don't worry.

(Update: one option is put the wordy instructions in a 'doc' directory, or add wiki, or Discussions topic, or something.)

abdullahalhoothy commented 8 months ago

yes i deleted it because it was alot of information while useful wasn't entirely about setup but rather file structure and dependencies, which are managed by npm anyway

i created a new file called setup dependencies with those information in there, i will move that into a doc directory