codeforbtv / expunge-vt

Generate more expungements. Deliver more justice.
Apache License 2.0
14 stars 6 forks source link

Move checkout #122

Closed jakedurell closed 4 years ago

jakedurell commented 4 years ago
  1. VLA headline in extension popup – keep users up to date with VLA news

  2. New settings menu with settings in one place

    • New VLA logo/footer checkbox – ensure generic logo and custom footer is overridden when preparing for VLA
    • Attorney/Preparer name, address, and phone
    • Preparer role (see role text in cover letter below - #5)
    • Custom Footer (applied when VLA logo option is not checked)
  3. All settings from #2 moved to local storage (will not be erased when browser is closed or when computer is restarted)

  4. Removed “Ineligible” option. Ensured that “No Filing” appears on checkout sheet.

  5. Add cover letter

  1. Remotely hosted adminConfig file (allows updating content instantly for all ExpungeVT users)

    • Expunge Headline (See #1)
    • RoleText - update default letter text as requested
    • County contact – put current county contact info on cover letter
  2. Move checkout sheet to top and redesign

    • Stipulation legend
    • Remove pro se text (added to letter)
    • Add arrest and offense dates
    • All counts appear on checkout even if no action taken (unless deleted)
  3. Remove extra checkout sheet

  4. Modifications for longer names

    • Adjusted caption (lines instead of parenthesis)
    • Top padding and lower z-index on left nav to allow for header room
  5. Remove remotely hosted code (CDN links)

    • A security measure which may allow for faster publishing times and faster load times.
jakedurell commented 4 years ago

@jeremyvermont -This is still a work in progress. Please look at branch if you have a sec. Something funny is happening on the print view where the NoA starts in the middle of the checkout sheet. Let me know if you have a chance for a quick call in the next week or so.

jakedurell commented 4 years ago

page break is resolved with last commit.

jeremyvermont commented 4 years ago

Things are working good overall! There is a UI regression on the start screen. The buttons are now taller and the icon is wrapping to a new line.

Before:

Screen Shot 2020-04-28 at 8 01 01 PM

After:

Screen Shot 2020-04-28 at 8 01 52 PM
jakedurell commented 4 years ago

@jeremyvermont - Thanks for your review. I fixed that issue which was just a problem with the newer version of bootstrap. I set the npm install to the CDN link we had before.

I have a few more things I want to do on this branch. I am going to delete the node modules now that I have package.json. It will make it easier for you to review the PR.

I am also going to add some things to the JSON, such as cover letter content, so that VLA can adjust content without having to republish the extension.

jeremyvermont commented 4 years ago

Sounds good, let me know when you want me to take another look.

jeremyvermont commented 4 years ago

Re-tested, looks good!