search

codeforcauseorg / archive.codeforcause.org

https://sandbox.codeforcause.org
Mozilla Public License 2.0
44 stars 78 forks source link

feat: add new eslint and prettier rules #130

Closed bklynate closed 4 years ago

bklynate commented 4 years ago

PR for issue: https://github.com/codeforcauseorg/codeforcause.org/issues/122

bklynate commented 4 years ago

@maverick-27

Abhishek-kumar09 commented 4 years ago

@bklynate Will you make another commit within this PR and run npm run format on that to see what are the changes that have introduced with this PR.

Abhishek-kumar09 commented 4 years ago

I guess it was already prompting to add semicolon.

bklynate commented 4 years ago

I ran npm run format.The code was well written and contained semi-colons already. I looked at 10 files and saw no issues but the rules were still missing - good to formally enforce @Abhishek-kumar09

bklynate commented 4 years ago

@Abhishek-kumar09 @maverick-27 - will this PR get merged?

Abhishek-kumar09 commented 4 years ago

Really sorry for the delay! Yes, it will be reviewed by the project maintainer then be merged. I am adding it to hacktoberfest label incase you were looking for that in this PR. We are currently busy with designs implementation for the new pages and other such stuffs, though your PR is remarkable.