search

codeforcauseorg / archive.codeforcause.org

https://sandbox.codeforcause.org
Mozilla Public License 2.0
44 stars 79 forks source link

Removing all the console errors from the development environment (#92). #197

Closed Itsaadarsh closed 3 years ago

Itsaadarsh commented 3 years ago

Removed all the console error's as mentioned in (#92), but as far as warnings are concerned there were 3 warnings that showed up in the development environment and they could only be cleared by upgrading packages but I didn't do that as I did not want to break any existing piece of code and on the flip side they only pop up on dev env and not on production env.

There is this workaround where I can write console.warn() => {} on root component which basically does not through any console warning what so ever but this practice is not good for the long run so I just let to be like that.

image

Abhishek-kumar09 commented 3 years ago

Thanks for your PR, one problem: This is broken: image

Itsaadarsh commented 3 years ago

Fixed CSS bug in Courses.js (#92) @Abhishek-kumar09

image

Abhishek-kumar09 commented 3 years ago

Please resolve conflicts.

Abhishek-kumar09 commented 3 years ago

package-lock.json has still conflicts.

Abhishek-kumar09 commented 3 years ago

You can rebase your branch on the development branch, as the changes are not synchronised. You previous merged PR has all the changes for package.json and some other files, still in the diff we are getting those files.

Rebasing your branch over latest development will solve this problem.

Itsaadarsh commented 3 years ago

Done mate @Abhishek-kumar09 , thanks for the guidance. Anything else?

Abhishek-kumar09 commented 3 years ago

One more thing, before you get into trouble of github rebase and anything like that. I have changed your package.json file and it may create some conflicts, either you could rebase or force push the branch for now. Since rebasing would cause a lot of problem to you since you have 6 commits history, therefore, you could force push your branch with ease after doing these changes, and then change the current package.json file to the the package.json file from the codeforcause.org repo.

Actually, I was about to merge this PR, thus changed your package.json file, but then found some minor issues.

Abhishek-kumar09 commented 3 years ago

Thanks @Itsaadarsh for your PR and your hardwork.

Itsaadarsh commented 3 years ago

@Abhishek-kumar09 My pleasure, let me know if something else is needed I'd love to contribute more.