search

codeforcauseorg / archive.codeforcause.org

https://sandbox.codeforcause.org
Mozilla Public License 2.0
44 stars 78 forks source link

Hire with Us Hero Component #206

Closed piall closed 3 years ago

piall commented 3 years ago

This PR is for the issue #200 .

piall commented 3 years ago

@Abhishek-kumar09 Sorry, I didn't understand. What you meant by the Lesson word

Abhishek-kumar09 commented 3 years ago

Oh Sorry, It is lessen meaning change padding to be little less than the usual desktop paddings when switched to smaller screens.

piall commented 3 years ago

Oh. No problem. I actually guessed that after thinking then I thought any keyword might be for professional works 🤣 Though I thought less on😂

piall commented 3 years ago

@Abhishek-kumar09 I got confused about reducing padding because I haven't used any 😅️. Though I have done some changes based on the screen. Please let me know if I made any mistakes. And please give me some guideline on asking questions maybe I am not asking questions properly because of my shyness( By thinking if I ask that question will it be lame or not).

piall commented 3 years ago

@Abhishek-kumar09 I have made changes.

Abhishek-kumar09 commented 3 years ago

Ya, its looking really good. I will review the changes after some time, if it is ok.

piall commented 3 years ago

Ya, its looking really good. I will review the changes after some time, if it is ok.

Take your time. I have no problem😃️

Abhishek-kumar09 commented 3 years ago

Thanks @mdPial for your wonderful contribution.

Abhishek-kumar09 commented 3 years ago

merging once ci pass

piall commented 3 years ago

Thanks @mdPial for your wonderful contribution.

Welcome. Feeling great, at last merged 😁️

Abhishek-kumar09 commented 3 years ago

You can also checkout click-short or certificate-generator-react they are also new projects that we are building now, but due some time constraints it is slow or could also try to solve some new issues in this repo.

piall commented 3 years ago

You can also checkout click-short or certificate-generator-react they are also new projects that we are building now, but due some time constraints it is slow or could also try to solve some new issues in this repo.

Thank you for the suggestion 😀️. I was looking to contribute as much as I can possible. Because I had gained the courage to contribute after watching videos of codeforcause 😁️. Thank you for guideline 😃️ along the way I never used Material UI before.

Abhishek-kumar09 commented 3 years ago

Thanks for your kind words.