search

codeforcauseorg / archive.codeforcause.org

https://sandbox.codeforcause.org
Mozilla Public License 2.0
44 stars 79 forks source link

Philosphy Component Added #220

Closed atharmohammad closed 3 years ago

atharmohammad commented 3 years ago

Fix #202

Added Component Philosphy in Hire With us update

atharmohammad commented 3 years ago

@Abhishek-kumar09 Review the Changes and let me know

Abhishek-kumar09 commented 3 years ago

Looks good, breaks on mobile. But currently I dont have mobile view. so changes are OK for me.

Abhishek-kumar09 commented 3 years ago

This thing breaks on firefox with 100% zoom level: image

atharmohammad commented 3 years ago

This thing breaks on firefox with 100% zoom level: image

Yes I see It's breaking on 100% zoom , What do you suggest,add some media-query for this?

atharmohammad commented 3 years ago

Looks good, breaks on mobile. But currently I dont have mobile view. so changes are OK for me.

Yes it breaking on mobile ,I will try to add some media queries

Abhishek-kumar09 commented 3 years ago

Yes it breaking on mobile ,I will try to add some media queries

You can do it with material-ui breakpoints: https://material-ui.com/customization/breakpoints/

Some files have these already implemented.

atharmohammad commented 3 years ago

Yes it breaking on mobile ,I will try to add some media queries

You can do it with material-ui breakpoints: https://material-ui.com/customization/breakpoints/

Some files have these already implemented.

Ok, I will see and implement it

atharmohammad commented 3 years ago

@Abhishek-kumar09 made the changes ,review it

Abhishek-kumar09 commented 3 years ago

Please resolve merge conficts.

atharmohammad commented 3 years ago

@Abhishek-kumar09 Done 👍

Abhishek-kumar09 commented 3 years ago

Excellent changes, loving your work. Thanks for the PR.