search

codeforcauseorg / archive.codeforcause.org

https://sandbox.codeforcause.org
Mozilla Public License 2.0
44 stars 78 forks source link

Create Hire-with-us component 4 #223

Closed Abhishek-kumar09 closed 3 years ago

Abhishek-kumar09 commented 3 years ago

The component to make: image

Please let me know about the any aditional file you want, and react out for any help with the issue.

niteshsinha17 commented 3 years ago

Hii, i would like to work on this. ☺ I will reach out to you for any requirements.

PrashubhAtri commented 3 years ago

Hey at what url would you like this page to be?? Also, any specific styling in mind or its upto us??

niteshsinha17 commented 3 years ago

I think it will be used in a different page as a component. Am I right? @Abhishek-kumar09

Abhishek-kumar09 commented 3 years ago

It is a subset of https://github.com/codeforcauseorg/codeforcause.org/issues/199

The pages and routes are already created you just have to make a component.

The route is /hirewithus

The page folder is https://github.com/codeforcauseorg/codeforcause.org/tree/development/src/views/pages/HireWithUsView

Just you have to make this component and import it here: https://github.com/codeforcauseorg/codeforcause.org/blob/development/src/views/pages/HireWithUsView/index.js

I will be sharing you the required files and images

Abhishek-kumar09 commented 3 years ago

To make those smaller shapes

position: absolute;
width: 46.66px;
height: 73.68px;

background: rgba(38, 46, 255, 0.1);
box-shadow: inset 0px 0px 50px rgba(0, 0, 0, 0.25);
border-radius: 300px 14px 760px 300px;
transform: rotate(-88.56deg);

Required files: hr4.zip

Abhishek-kumar09 commented 3 years ago

make sure you are working with latest development branch.

PrashubhAtri commented 3 years ago

The component to be imported is to be added at the very top ?? like i have to add it to the top of pre existing page? PLease help this is my first time contributing to Open Source

Abhishek-kumar09 commented 3 years ago

Hire With us-min.pdf

First of all, let me know who is working on this issue and who like to take up @PrashubhAtri @niteshsinha17 so as to avoid confusion and redundant PR.

PrashubhAtri commented 3 years ago

I am willing to work and have started creating the component If thats fine @niteshsinha17 ??

niteshsinha17 commented 3 years ago

I have started to work on it since I have commented. It will great if @Abhishek-kumar09 can help in this situation. Thank you.

Abhishek-kumar09 commented 3 years ago

I don't know but since @niteshsinha17 has commented earlier on this issue with quote: "Hii, i would like to work on this.", this particular issue goes to him.

I would like to ask for apology from @PrashubhAtri.

But no worries I will be assigning and giving you a brand new issue to work on, chill.

PrashubhAtri commented 3 years ago

no problem I understand. Looking forward to some new issues to work on.

niteshsinha17 commented 3 years ago

@Abhishek-kumar09 Hii, I have created the required component but I want to know what to do with image part in phone view. Should I hide it or show it at the bottom of the text?

Abhishek-kumar09 commented 3 years ago

In the phone view, the image should come up followed by the text and then button

niteshsinha17 commented 3 years ago

To make those smaller shapes

I think we can use those shapes as image and position them as their position. If you agree then I can create it, else I will be styling them using css.

Abhishek-kumar09 commented 3 years ago

Whatever you like, do you need the images

To make those smaller shapes

I think we can use those shapes as image and position them as their position. If you agree then I can create it, else I will be styling them using css.

niteshsinha17 commented 3 years ago

If you can have then please send. Otherwise I will design it.

Abhishek-kumar09 commented 3 years ago

Rectangle 103.zip

Just rotate and resize these and things will work fine.

niteshsinha17 commented 3 years ago

Thanks

niteshsinha17 commented 3 years ago

Hii, npm run format is formatting every file. It will show changes in my PR. what should I do?

niteshsinha17 commented 3 years ago

I have checked it again. No file is actually changed accept few ones but why they are showing changed by the git? I think it may not reflect in my PR.

Abhishek-kumar09 commented 3 years ago

npm run format formats your code that should align to pre-written coding style configuration. It is required to run npm run format after doing cchanges so that code comes in a good written format. You can add those changes to git and commit it in the PR.

Abhishek-kumar09 commented 3 years ago

@niteshsinha17 Create a PR and we will discuss further steps there.

niteshsinha17 commented 3 years ago

I have created PR for it.