Adds a Dynamic Data based profile Page with cards and recently played functionality

codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.

https://educlient.codeforcause.org/

MIT License

130 stars 149 forks source link

Adds a Dynamic Data based profile Page with cards and recently played functionality #120

Closed Devesh21700Kumar closed 3 years ago

Devesh21700Kumar commented 3 years ago

fixes # Adds a Dynamic Data based profile Page

Describe the changes you've made

A profile page made with Avatar and first five of the recently played videos by a person Mobile view

Mobile View

desktop view

desktop view scrolled down

i've set slice(0,5) before mapping so in recently played only 1st 5 will appear.. its different from history

Checklist

[x ] My code follows the code style of this project.
[ x] All new and existing tests passed.
[x ] The title of my pull request is a short description of the requested changes.

Devesh21700Kumar commented 3 years ago

@Abhishek-kumar09 please review the PR @rizwan2000rm please review the PR

kaiwalyakoparkar commented 3 years ago

Can you center the log-out button. As it is in fill-parent it looks somewhat absurd. If you could make it of the same size but center aligned then it would look great.
Please change the gradient of red to a somewhat darker red
Highlight the Logout text
If the logout button is at the top then it will make the design more sustainable. Else if the user has registered for many courses. He will have to scroll a long way down.

Devesh21700Kumar commented 3 years ago

Can you center the log-out button. As it is in fill-parent it looks somewhat absurd. If you could make it of the same size but center aligned then it would look great.

Please change the gradient of red to a somewhat darker red

Highlight the Logout text

If the logout button is at the top then it will make the design more sustainable. Else if the user has registered for many courses. He will have to scroll a long way down.

sure .. Thanks

Devesh21700Kumar commented 3 years ago

Can you center the log-out button. As it is in fill-parent it looks somewhat absurd. If you could make it of the same size but center aligned then it would look great.

Please change the gradient of red to a somewhat darker red

Highlight the Logout text

If the logout button is at the top then it will make the design more sustainable. Else if the user has registered for many courses. He will have to scroll a long way down.

Mobile view

Desktop view

Devesh21700Kumar commented 3 years ago

@Abhishek-kumar09 @KeenWarrior pls see

Abhishek-kumar09 commented 3 years ago

The profile page design is in progress, your work is appreciated and acknowledged! Thanks for the PR

Abhijay007 commented 3 years ago

@Devesh21700Kumar I think you can close this PR now as there is already a profile Page that exists in the main branch and as @adarsh-technocrat is working on a new UI design we may need to make a profile page according to that design.