Resolved bottom Navbar Text wrap for all screens

codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.

https://educlient.codeforcause.org/

MIT License

130 stars 149 forks source link

Resolved bottom Navbar Text wrap for all screens #129

Closed Abhijay007 closed 3 years ago

Abhijay007 commented 3 years ago

fixes #114

Describe the changes you've made

using CSS media query I resolved the text wrap bug in "MyClass" for the smallest screens possible (galaxy fold, I phone 5 ) in mobile view.

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

NA

How someone can test your code?

using chrome inspect

Checklist

[x] My code follows the code style of this project.
[x] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.

Abhijay007 commented 3 years ago

On Sun, 21 Mar 2021, 22:29 Rajat Gupta, @.***> wrote:

@.**** approved this pull request.

LGTM

In src/layouts/MainLayout/BottomNav.css https://github.com/codeforcauseorg/edu-client/pull/129#discussion_r598308022 :

@@ -2,10 +2,35 @@ border-bottom: 2px solid #3949ab; }

-.MuiBottomNavigationAction-label.Mui-selected{

font-size: 0.8rem !important; +.Mui-selected{

font-size: 0.8rem !important ;

Can you please remove this space.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/codeforcauseorg/edu-client/pull/129#pullrequestreview-617040784, or unsubscribe https://github.com/notifications/unsubscribe-auth/APLHP3SF5244PSGBFONUJTLTEYQWXANCNFSM4ZRWHYUA .