search

codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.
https://educlient.codeforcause.org/
MIT License
130 stars 149 forks source link

aligned back-to-top button to extreme bottom #138

Closed Abhijay007 closed 3 years ago

Abhijay007 commented 3 years ago

Describe the changes you've made

Aligned back to top button to extreme bottom of the page in order to improve UI as it is currently in middle somewhere which will not justify its use.

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

NA

Additional context (OPTIONAL)

before before-backToTop

after after-backToTop

Checklist

Abhijay007 commented 3 years ago

Hi @Abhijay007, the changes you made are good but can you also remove the extra space btw the cards and the button.

Ok thanks, @rajatgupta24 for reviewing this PR, I will try to remove that space 👍

Abhishek-kumar09 commented 3 years ago

Hi @Abhijay007, the changes you made are good but can you also remove the extra space btw the cards and the button.

yes, that is main problem, page height is more than actual required height.

Abhijay007 commented 3 years ago

Hi @Abhijay007, the changes you made are good but can you also remove the extra space btw the cards and the button.

yes, that is main problem, page height is more than actual required height.

@rajatgupta24 @Abhishek-kumar09 can you please help me with this height issue, I tried to resolve it for the past 5 days but not able to find any optimized solution. i think that some of the container classes overwriting each other which leds to this height issue as you can see in the console snip below there are some of the containers that form a hierarchy.

containers-console

these containers are overwriting the properties of each other.

I try to manipulate height using inline CSS and even use ! Important property of CSS in order to ignore that overwriting thing but not able to find any thing fruitful, I don't know where I made the mistake can you please help me with this or suggest me something to solve this.

Abhishek-kumar09 commented 3 years ago

Hi @Abhijay007, the changes you made are good but can you also remove the extra space btw the cards and the button.

yes, that is main problem, page height is more than actual required height.

@rajatgupta24 @Abhishek-kumar09 can you please help me with this height issue, I tried to resolve it for the past 5 days but not able to find any optimized solution. i think that some of the container classes overwriting each other which leds to this height issue as you can see in the console snip below there are some of the containers that form a hierarchy.

containers-console

these containers are overwriting the properties of each other.

I try to manipulate height using inline CSS and even use ! Important property of CSS in order to ignore that overwriting thing but not able to find any thing fruitful, I don't know where I made the mistake can you please help me with this or suggest me something to solve this.

Okay No problem, we can check that out after some time. Till then you can try some other issues or write your proposal

Abhijay007 commented 3 years ago

closing this PR, related to previous UI design : )