Closed poojadas07 closed 3 years ago
@poojadas07 I reviewed your code and there are some things I want to suggest:
- There are some indentations and code style errors because of which these CI tests failed, you can easily resolve those errors just by following console warnings.
for ex: follow these warnings
As you can see in the above snip that in the console there are some warnings with line number and folder name, you just need to add and remove some spaces in order to solve this.
- Every time user opens the doubt form(peer section) on the profile page then the whole website reloads itself which made it look like a static site which led some problems in the android version, I think it is a routing issue. you can easily resolve it by doing some minor changes
I think that this page reload thing is happening because of this line:
onPress: () => { window.location.href='/peer' },
as you used the
window
object it will reload itself because the window object in javascript reopersents the browser window.
- UI looks a bit inconsistent as compared to the whole site (for ex: color scheme and buttons in mobile view in peer page ) but our main focus is not UI right now we can improve that over time. you can make a separate PR in order to improve UI or you can raise a separate issue to improve UI if you are not interested in designing work, I will take care of that.
okay ....I will check this one
@Abhishek-kumar09 Please check this PR.
Issue Number
fixes #136
Describe the changes you've made
I added a design for peer discussion page
Checklist