search

codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.
https://educlient.codeforcause.org/
MIT License
130 stars 149 forks source link

Removed video-react and replaced it with React Player #161

Closed rizwan2000rm closed 2 years ago

rizwan2000rm commented 3 years ago

Issue Number

fixes #149

Describe the changes you've made

Replaced video-react with react-player. Uninstalled video-react package from the project.

Abhishek-kumar09 commented 3 years ago

Please Remove merge conflicts

rizwan2000rm commented 3 years ago

@Abhishek-kumar09 Done. I have integrated the changes according to new folder structure.

Abhishek-kumar09 commented 3 years ago

Thanks @rizwan2000rm This is halted for some time, though it counts in your contribution. I have halted it to check som more things which I could not check it now.

You can carry on to other PRs, I will get back to this after some time, and then we will do the required changes if any together.

rizwan2000rm commented 3 years ago

@Abhishek-kumar09 Sure. No problem.

Abhijay007 commented 3 years ago

@rizwan2000rm resolve merge conflicts. pull upstream changes for that :)

rizwan2000rm commented 3 years ago

@Abhijay007 This PR is halted for detailed review from @Abhishek-kumar09

rizwan2000rm commented 3 years ago

If this has to be tested now let me know I will fix the conflicts soon @Abhijay007 @Abhishek-kumar09

Abhishek-kumar09 commented 3 years ago

Will update you on this.

Abhijay007 commented 3 years ago

@rizwan2000rm I think that this change will get covered In this PR (#367) you can close this PR if you want :)

Abhishek-kumar09 commented 3 years ago

No please keep it open. It's a good reference and thanks @rizwan2000rm for this PR