Fix: continue learning cards

codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.

https://educlient.codeforcause.org/

MIT License

130 stars 149 forks source link

Fix: continue learning cards #164

Closed naveen8801 closed 3 years ago

naveen8801 commented 3 years ago

Issue Number

fixes #140

Describe the changes you've made

styling of 'root' section in 'coursecard1' component edited , stylings for 'List' element added in 'Non.Hero.js'

Additional context (OPTIONAL)

Screenshot (33)

Test plan (OPTIONAL)

A good test plan should give instructions that someone else can easily follow.

Checklist

[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

adarsh-technocrat commented 3 years ago

Hello, @naveen8801 thanks for the PR I have some suggestions related to PR when it comes to mobile application View and use case for adding a Horizontal Scroll View we don't see that horizontal Scroll bar right! so if @Abhishek-kumar09 agrees with the point you can go for removing the horizontal Scroll bar and you can remove other horizontal Scroll bar as well :)

adarsh-technocrat commented 3 years ago

@naveen8801 Can you please go for resolving that deleted package-lock.json file from your PR as that should not be included in your PR :)

naveen8801 commented 3 years ago

Hii @adarsh-technocrat , thanks for suggestion , i have implemented all the changes suggested by you .

Screenshot (35)

But my test cases are falling , please help !

adarsh-technocrat commented 3 years ago

Actually, there are some prettier issues resolve that

src/pages/HomeView/NonHero.js
  Line 19:14:  Replace `·:·"none"` with `:·"none",`  prettier/prettier
  Line 42:1:   Delete `··`                           prettier/prettier