search

codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.
https://educlient.codeforcause.org/
MIT License
130 stars 149 forks source link

Added Go-Back and Scroll-To-top functionality to Course Description page #169

Closed Abhijay007 closed 3 years ago

Abhijay007 commented 3 years ago

Describe the changes you've made

Added Go-back on wishlist page functionality on click of back arrow button in course description page and Added scroll to top button also

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

NA

Additional context (OPTIONAL)

After

after-courseDesc

Checklist

Abhijay007 commented 3 years ago

@Abhishek-kumar09 I think there are some errors exists in the main code

faisaljamil25 commented 3 years ago

Hi @Abhijay007 I have changed the CourseDetail.js location in PR #177 so it would raise conflicts if either one of our PR's gets merged. So to resolve this issue you can move the file inside CourseDetail folder and rename it to index.js

Abhijay007 commented 3 years ago

Ok

On Wed, 31 Mar 2021, 11:11 Abhishek Kumar, @.***> wrote:

@Abhishek-kumar09 commented on this pull request.

In src/layouts/MainLayout/BottomNav.css https://github.com/codeforcauseorg/edu-client/pull/169#discussion_r604607623 :

.Mui-selected {

  • font-size: 0.77rem !important;
  • font-size: 0.7rem !important; } }

@media screen and (max-width: 321px) and (min-width: 320px) { .Mui-selected {

  • font-size: 0.67rem !important;
  • font-size: 0.6rem !important; } .MuiBottomNavigationAction-label {
  • font-size: 0.66rem !important;
  • font-size: 0.6rem !important;

revert this, fixed it in the latest code

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/codeforcauseorg/edu-client/pull/169#pullrequestreview-624908040, or unsubscribe https://github.com/notifications/unsubscribe-auth/APLHP3SIHSMAD5TURWN6IHLTGKYYZANCNFSM42BUDSKQ .

Abhijay007 commented 3 years ago

Hi @Abhijay007 I have changed the CourseDetail.js location in PR #177 so it would raise conflicts if either one of our PR's gets merged. So to resolve this issue you can move the file inside CourseDetail folder and rename it to index.js

ok, @faisaljamil25 I will do that, thanks for letting me know about it !!