search

codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.
https://educlient.codeforcause.org/
MIT License
130 stars 149 forks source link

added a missing icon import "PlayCircleOutline" #175

Closed cosmo3769 closed 3 years ago

cosmo3769 commented 3 years ago

When I recently pulled the changes and ran "npm start", I found an error. The error was a missing icon import that is "PlayCircleOutline" in layout BottomNav section.

Abhijay007 commented 3 years ago

@piyush-cosmo but there is a routing issue also exists.

cosmo3769 commented 3 years ago

@Abhijay007 I find no problem in running. Will you elaborate more about the issue you are mentioning?

Abhijay007 commented 3 years ago

@Abhijay007 I find no problem in running. Will you elaborate more about the issue you are mentioning?

@piyush-cosmo this one :

bug-routing

as you can see both Home and MyClass pages are the same.

faisaljamil25 commented 3 years ago

@Abhijay007 I find no problem in running. Will you elaborate more about the issue you are mentioning?

as you can see both Home and MyClass pages are the same.

@Abhijay007 this is because route /personal doesn't exist yet and therefore it redirects to /home

sakshi-choudhary commented 3 years ago

@piyush-cosmo but there is a routing issue also exists.

The routing issue was fixed

Abhijay007 commented 3 years ago

@piyush-cosmo but there is a routing issue also exists.

The routing issue was fixed

bug-routing

but @sakshi-choudhary I made this video after pulling the latest changes from the main branch can you please cross-check it once and confirm it. Because I am not sure that something wrong in my code or it exists globally in the main branch.

Abhijay007 commented 3 years ago

@piyush-cosmo but there is a routing issue also exists.

The routing issue was fixed

bug-routing

but @sakshi-choudhary I made this video after pulling the latest changes from the main branch can you please cross-check it once and confirm it. Because I am not sure that something wrong in my code or it exists globally in the main branch.

@sakshi-choudhary ignore this, this is resolved in the latest changes