search

codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.
https://educlient.codeforcause.org/
MIT License
130 stars 149 forks source link

Changing the App Title #188

Closed dhwaj1902 closed 3 years ago

dhwaj1902 commented 3 years ago

Change the App Title from 'React App' to 'Edu Client'. image

dhwaj1902 commented 3 years ago

By mistake I have made pull request in another issue, This is the pr for this issue Pr

Abhijay007 commented 3 years ago

@dhwaj1902 we may don't need it right now as our main focus is the android app that's why we do not even replace our favicon for now but if you really wanna change it try to make changes in your existing PR as I think to open a separate pr for this may not that fruitful. And I think Edu-client is not a permanent name it will be replaced in the future as it is a project name, not an APP name.

PS: I am not a maintainer you might need approval for this from @Abhishek-kumar09

dhwaj1902 commented 3 years ago

@Abhishek-kumar09 can close this issue because I already pushed my changes to this commit

karankv26 commented 3 years ago

@Abhishek-kumar09 done bro...

dhwaj1902 commented 3 years ago

@karankv26 bro I have already pushed the changes and the pr is already merged. I asked @Abhishek-kumar09 to close this issue.

karankv26 commented 3 years ago

Ohh okay...fine...

rizwan2000rm commented 3 years ago

@dhwaj1902 You can close it yourself as you are the author of this issue.