search

codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.
https://educlient.codeforcause.org/
MIT License
130 stars 149 forks source link

refactor Discussion page and improved UI #192

Closed Abhijay007 closed 3 years ago

Abhijay007 commented 3 years ago

Describe the changes you've made

Removed incline CSS code and added internal CSS styles as most of the codebase use that, and improved UI for the description page

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

NA

Additional context (OPTIONAL)

desc page-1 desc page-2

Checklist

Siddhant-K-code commented 3 years ago

Describe the changes you've made

Removed incline CSS code and added internal CSS styles as most of the codebase use that, and improved UI for the description page

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

NA

Additional context (OPTIONAL)

desc page-1 desc page-2

Checklist

  • [x] My code follows the code style of this project.
  • [x] All new and existing tests passed.
  • [x] The title of my pull request is a short description of the requested changes.

Hey, Can you pls also add the URL ( which you made the changes ) -- it can be done when netlify deploy preview tests get passed.

You can get from here

image

And Just Add the exact URLs in which you made changes, like https://deploy-preview-192--festive-allen-a7f545.netlify.app/profile or https://deploy-preview-192--festive-allen-a7f545.netlify.app/home or else.

it will make it easier to review your PRs

Abhijay007 commented 3 years ago

ok @Siddhant-K-code here it is.

Abhishek-kumar09 commented 3 years ago

Looks good, thanks @Abhijay007