adding information in contribution file related to node.js download

codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.

https://educlient.codeforcause.org/

MIT License

130 stars 149 forks source link

adding information in contribution file related to node.js download #194

Closed ravikr126 closed 3 years ago

ravikr126 commented 3 years ago

Issue Number

fixes #

Describe the changes you've made

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

Additional context (OPTIONAL)

Test plan (OPTIONAL)

A good test plan should give instructions that someone else can easily follow.

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] The title of my pull request is a short description of the requested changes.

ravikr126 commented 3 years ago

Hii @Abhishek-kumar09 many student-facing same problem regarding download node.js in their system.so I specifically write that which version is good for download .kindly review my PR and . If any suggestion please message me

ravikr126 commented 3 years ago

Hi @ravikr126, thanks for contributing, you're making some changes in a package-lock file, to resolve it just copy the package-lock file from the main repo and paste it in your local repo then push again, please rename the ravi.env file to .env.

Hii @rajatgupta24 bhaiya in which folder package-lock file available. I didn't find that folder. please give me path then I will add it to my local system.

Abhishek-kumar09 commented 3 years ago

This is package-lock.json https://github.com/codeforcauseorg/edu-client/blob/main/package-lock.json

ravikr126 commented 3 years ago

thanks @Abhishek-kumar09 bhaiya

ravikr126 commented 3 years ago

I added some missing files please check my pr . @Abhishek-kumar09

ravikr126 commented 3 years ago

please check this pull request and any changes need please tell me @Abhishek-kumar09

Abhijay007 commented 3 years ago

@ravikr126 I think this change is not needed as these are very minimal changes, you can cover these changes in any other PR. I think you can close this PR for now :)