search

codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.
https://educlient.codeforcause.org/
MIT License
130 stars 149 forks source link

add UI fixes and create a component based structure #222

Closed Devesh21700Kumar closed 3 years ago

Devesh21700Kumar commented 3 years ago

1).Changed this (also now one can change avatar based on name's first letter)

image

2). Instead of copying and pasting the same thing, i made a discussion component and mapped it for better modularity

Devesh21700Kumar commented 3 years ago

@Abhishek-kumar09 modularity based and UI based changes. Please do check

sakshi-choudhary commented 3 years ago

@Devesh21700Kumar I think we should not show all the responses of a particular doubt on the same page as one doubt can have 100s of comments, so we can here follow the way Instagram does it. i.e we can write below the doubt 123 responses and on clicking on that the responses should open in a different page.

Abhijay007 commented 3 years ago

@Devesh21700Kumar you can close this PR for now as Discussion from is refactored from this PR(#290), and your PR is based on the previous design so we may don't need this. btw thanks for PR :)