codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.
https://educlient.codeforcause.org/
MIT License
130 stars 149 forks source link

Updated: pull_request_template.md file #233

Closed adarsh-technocrat closed 3 years ago

adarsh-technocrat commented 3 years ago

Issue Number

fixes #234

Describe the changes you've made

Update PR template which asks for giving links to the deploy preview of the route/page that needs to review!

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

Additional context (OPTIONAL)

Test plan (OPTIONAL)

A good test plan should give instructions that someone else can easily follow.

Checklist

adarsh-technocrat commented 3 years ago

That's why this branch is based on the student dashboard screen branch instead of main, you can easily roll back these code commits and you may also need to pull upstream once as I think there are some conflicts in the list component which may occur due to recent changes in main branch although code looks good for the PR template 👍 .

This huge comment scarred me at first look 😄. resolved it thanks @Abhijay007