Fix- Overexposed shadow blur radius of cards

codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.

https://educlient.codeforcause.org/

MIT License

128 stars 148 forks source link

Fix- Overexposed shadow blur radius of cards #236

Closed naveen8801 closed 3 years ago

naveen8801 commented 3 years ago

Issue Number

fixes #225 - Fix- Overexposed shadow blur radius of cards

Describe the changes you've made

i have added css style boxShadow: "0px 0px 5px rgba(0,0,0,0.2)" in wishlistCard component, courseCard component and in HomeView page.

After Changes

border_shadow

[x] My code follows the code style of this project.
[x] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.

adarsh-technocrat commented 3 years ago

Hey @naveen8801 you have not made changes to all the cards which have this issue, you can go for making changes to the rest of the cards too :)

naveen8801 commented 3 years ago

Hey @naveen8801 you have not made changes to all the cards which have this issue, you can go for making changes to the rest of the cards too :)

sure @adarsh-technocrat 👍

naveen8801 commented 3 years ago

Hi @Abhishek-kumar09 @adarsh-technocrat , i found className={classes.li} in NonHero.js file in props passed to ListItem element , i think there is no use of this line because no such class exist , it may confuse some new comers so should i remove it ? :)

Screenshot (51)_LI

adarsh-technocrat commented 3 years ago

@naveen8801 you can remove that!

adarsh-technocrat commented 3 years ago

Hey, @naveen8801 can you please resolve the merge conflict?

naveen8801 commented 3 years ago

Hey, @naveen8801 can you please resolve the merge conflict?

Hii @adarsh-technocrat , i have resolved the conflict , please review :))

Abhijay007 commented 3 years ago

@naveen8801 you can close this PR now as this issue is resolved from this PR (#327)