codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.
https://educlient.codeforcause.org/
MIT License
128 stars 148 forks source link

Added Tech stack section in Job card ! #255

Closed rohan-kulkarni-25 closed 3 years ago

rohan-kulkarni-25 commented 3 years ago

Issue Number

fixes #254

Describe the changes you've made I have added tech stack section in job card

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't) NA

Additional context (OPTIONAL)

Test plan (OPTIONAL)

A good test plan should give instructions that someone else can easily follow.

Checklist

Provide a Deployed link of route/page that needs to review

Preview: here

Screenshot 2021-04-11 220322

imabp commented 3 years ago

@rohank2502 Please follow the proper linting. You need to delete the extra line, you have put in the following file, as shown in the image. image

rohan-kulkarni-25 commented 3 years ago

Oo okok

On Sun, Apr 11, 2021, 10:51 PM Abir @.***> wrote:

@rohank2502 https://github.com/rohank2502 Please follow the proper linting. You need to delete the extra line, you have put in the following file, as shown in the image. [image: image] https://user-images.githubusercontent.com/53480076/114314445-45f2ea00-9b18-11eb-95b8-fa5f6dafedb4.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/codeforcauseorg/edu-client/pull/255#issuecomment-817341555, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASIJKM3R45KSDYOQIJGMSQLTIHLAFANCNFSM42X24QIQ .

rohan-kulkarni-25 commented 3 years ago

@rohank2502 Please follow the proper linting. You need to delete the extra line, you have put in the following file, as shown in the image. image

Thanks !! Just one line messed up all!

imabp commented 3 years ago

@Abhishek-kumar09 please review this, tagging you, as he is not requested your review :P .

One tip: @rohank2502, you can request reviewers for your PR.

rohan-kulkarni-25 commented 3 years ago

Ok I will keep in mind

On Sun, Apr 11, 2021, 11:09 PM Abir @.***> wrote:

@Abhishek-kumar09 https://github.com/Abhishek-kumar09 please review this, tagging you, as he is not requested your review :P .

One tip: @rohank2502 https://github.com/rohank2502, you can request reviewers for your PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/codeforcauseorg/edu-client/pull/255#issuecomment-817344055, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASIJKM6NOBLJHTORDJOTMP3TIHNEXANCNFSM42X24QIQ .

Abhishek-kumar09 commented 3 years ago

https://github.com/codeforcauseorg/edu-client/pull/255#discussion_r613295253

rohan-kulkarni-25 commented 3 years ago

@Abhishek-kumar09 Please give it a Check !

Abhishek-kumar09 commented 3 years ago

To me this is not looking appropriate, the user will have a job description page where they will get any extra information.

For a card, the informations on it are enough ie, job title, short description and it's type.

Adding more chips will make it more bigger and less surprise for the actual job page.