codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.
https://educlient.codeforcause.org/
MIT License
130 stars 149 forks source link

The back button is not required. #270

Closed ADRE9 closed 3 years ago

ADRE9 commented 3 years ago

Describe the bug

The back button is not required and if also it is kept it should not work as a back button of browser that on getting clicked changes the page to the last visited page, since the UI of app dies using the back button and it looks for of a webapp.

To Reproduce

Steps to reproduce the behavior:

1.To remove back button from the header 2.Or if not to attach the route of left page so that on clicking back user goes to the previous page.

Environment (please complete the following information):

ADRE9 commented 3 years ago

@Abhishek-kumar09 @KeenWarrior do you think the functionality of the back button well defined?

rizwan2000rm commented 3 years ago

You are talking about the back button on Course Details Page ?

ADRE9 commented 3 years ago

The one at the header at every page except the Home page.

Abhishek-kumar09 commented 3 years ago

As you have thought the back is not needed on the MainLayout pages, since there is bottomNavigation to handle all those things.

But we will be needing back button on independent pages.

Is using hisstory.goBack() is making any problem for app UX @ADRE9

ADRE9 commented 3 years ago

Yes , that's okay for other pages but for the main pages that can b navigated through the bottom navigation the default behaviour must be to visit the left page instead of going back in history, I guess that's the default behaviour for the mobile applications. So we can reconfigure the back button for these pages or totally remove it for main pages.

Abhishek-kumar09 commented 3 years ago

Totally Agree.

Abhishek-kumar09 commented 3 years ago

Do you want to work on it?

ADRE9 commented 3 years ago

Yes please , but should I remove it or should I just re-route to the previous pages?

Abhishek-kumar09 commented 3 years ago

remove it.