UI for About Us page - Githubissues

codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.

https://educlient.codeforcause.org/

MIT License

130 stars 149 forks source link

UI for About Us page #275

Closed poojadas07 closed 3 years ago

poojadas07 commented 3 years ago

Issue Number

fixes #266

Describe the changes you've made

I added the 3 different sections in About Us page with different UI.

Checklist

[x] My code follows the code style of this project.
[] My change requires a change to the documentation.
[] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.

adarsh-technocrat commented 3 years ago

Hey, @poojadas07 please add deployed preview link of route/page in your PR description which needs to review!

adarsh-technocrat commented 3 years ago

And I would suggest you sync your local branch with the main upstream branch as there are some commits that are not needed in this PR!

adarsh-technocrat commented 3 years ago

Hey @poojadas07 can you make the About Us page UI a mobile-friendly one you can see it's not responsive and there is no proper margin between those avatars because of that you can see the right margin on the app Bar.

poojadas07 commented 3 years ago

Hey @poojadas07 can you make the About Us page UI a mobile-friendly one you can see it's not responsive and there is no proper margin between those avatars because of that you can see the right margin on the app Bar.

okay

poojadas07 commented 3 years ago

@Abhishek-kumar09 please check !!

poojadas07 commented 3 years ago

@Abhishek-kumar09 I added all the requested changes. Please check !!

poojadas07 commented 3 years ago

@Abhishek-kumar09 please check and let me know.

Abhishek-kumar09 commented 3 years ago

Looking good now!