Minor UI and Alignment fixes

codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.

https://educlient.codeforcause.org/

MIT License

130 stars 149 forks source link

Minor UI and Alignment fixes #296

Closed Abhijay007 closed 3 years ago

Abhijay007 commented 3 years ago

fixes #303

Describe the changes you've made

Minor UI and Alignment fixes for smaller width devices for smaller devices, UI gets overflowed in some cases.

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

NA

Checklist

[x] My code follows the code style of this project.
[x] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.

Provide a Deployed link of route/page that needs to review

Preview: https://deploy-preview-296--edu-client.netlify.app/peer

Referral Page :https://deploy-preview-296--edu-client.netlify.app/referralAndCoupons

sakshi-choudhary commented 3 years ago

@Abhijay007 I think there's an issue. It doesn't delete that particular item I select, it deletes the item at the last.

Abhishek-kumar09 commented 3 years ago

I don't know the deploy preview is not working right now in my browser, shows a blank page when I move to this route deploy-preview-296--festive-allen-a7f545.netlify.app/wishlist

Is it same in your case?

Abhishek-kumar09 commented 3 years ago

Github, rebase

Abhijay007 commented 3 years ago

@Abhishek-kumar09 I modified this PR for UI and alignment changes as this issue (#256) is already closed by this(#304) PR.

Abhishek-kumar09 commented 3 years ago

What are the different alignment issues you are fixing?

Abhijay007 commented 3 years ago

What are the different alignment issues you are fixing?

post something UI:

before	after

the post-pop-up is not aligned for smaller devices it is slightly left or right according to the device's width but not centered.

Peer page:

befor	after

on web:

before alignemt post something

after

fixed align

Abhijay007 commented 3 years ago

On Wed, 5 May 2021, 23:57 Abhishek Kumar, @.***> wrote:

@Abhishek-kumar09 requested changes on this pull request.

Awesome, lots of fixes.

The changes in referral and coupons has introduced horizontal instability on smaller screens.Please revert

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/codeforcauseorg/edu-client/pull/296#pullrequestreview-652620299, or unsubscribe https://github.com/notifications/unsubscribe-auth/APLHP3S5MNKA7YQDIYM3FHDTMGEXRANCNFSM43WMS45Q .