Closed RohankumarM closed 3 years ago
@RohankumarM code looks good to me but there is a slight delay in deleting animation, it lags a bit. To resolve this you may possibly need to reduce animation time a bit.
You may need mentor's suggestion for this as I just mentioned what I observed 😅 maybe this animation works like this( with a delay).
@RohankumarM I think the code is not working now means it not showing any animation on deleting a wishlist component please cross-check it once may be due to recent upstream changes code may not be pushed, as it was working before.
@RohankumarM code is working fine now, just remove external CSS files and add them into the
makeStyles
of files they are associated with.
You can also wait for the mentor's suggestions and pushed commits after their suggestions as it may be difficult and a bit annoying for you to keep pushing changes one by one.
@adarsh-technocrat Review the latest changes please and let me know if anything needs an improvement.
@adarsh-technocrat Review the latest changes please and let me know if anything needs an improvement.
LGTM !!
308
Added exit animation when deleting a course from Wishlist which would make increase visual accessibility and makes it easier for user to understand that something has been deleted.