codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.
https://educlient.codeforcause.org/
MIT License
130 stars 149 forks source link

Added Popular course section In Home Page #343

Closed adarsh-technocrat closed 3 years ago

adarsh-technocrat commented 3 years ago

Describe the changes you've made

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

Added Popular course section In Home Page

Additional context (OPTIONAL)

Test plan (OPTIONAL)

A good test plan should give instructions that someone else can easily follow.

Checklist

Provide a Deployed link of route/page that needs to review Preview: Deployed preview link

Cc: @Abhishek-kumar09

Abhishek-kumar09 commented 3 years ago

Can we have some more bottom padding in the cards image

netlify[bot] commented 3 years ago

A reviewer left a comment:

Had you added any content in Popular Courses?

Browser metadata ``` Path: /home Browser: Firefox 88.0 on Ubuntu Viewport: 1314 x 706 @1x Language: en-US Cookies: Enabled ``` [View on BrowserStack](https://live.browserstack.com/dashboard#url=https%3A%2F%2Fdeploy-preview-343--edu-client.netlify.app%2Fhome&os=OS+X&os_version=Big+Sur&browser=Firefox&browser_version=88.0&resolution=1314x706&speed=1&start=true)

Open Deploy Preview · Mark as Resolved

adarsh-technocrat commented 3 years ago

Can we have some more bottom padding in the cards image

@Abhishek-kumar09 I have made all minor changes in the upcoming PR which resolves all these issues :)

adarsh-technocrat commented 3 years ago

A reviewer left a comment:

Had you added any content in Popular Courses?

Browser metadata Open Deploy Preview · Mark as Resolved

Yes, will be shortly pushing the changes from the local branch :)

adarsh-technocrat commented 3 years ago

@Abhishek-kumar09 I'll destructure the props as I implement the mock data to the component!