codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.
https://educlient.codeforcause.org/
MIT License
130 stars 150 forks source link

Login Page added #43

Closed atharmohammad closed 3 years ago

atharmohammad commented 3 years ago

issue #21

Describe the changes you've made

Added Login Page on Route /login and only when any account is logged in currently via google can access other routes and after user is logged in he can not access login page , currently just a testing loggedin variable is stored when logged in using google in localStorage , to test you can login using google and to logout just clear cache of your browser

you can see login page at route /login

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

After logging in via google , I tried to redirect it to home using history.push('/home') after dispatch but redirect is not occuring I tried it by async await but nothing happens , So currently if you want to go to '/home' you have to type mannualy after logging in, I am looking into this Tell me if there is a way

Checklist

log

atharmohammad commented 3 years ago

@Abhishek-kumar09 can you look in changes and tell me what I have to change more

KeenWarrior commented 3 years ago

For now, we only wish to have Login with Google

atharmohammad commented 3 years ago

@KeenWarrior I have made the changes , can you please review it log

atharmohammad commented 3 years ago

@Abhishek-kumar09 I have made changes tell me if any thing you want me to change

KeenWarrior commented 3 years ago

@atharmohammad Hey I am closing this PR in regards to #68

Login was becoming a roadblock for other stuff.

Kudos for your work though. Directly took your Login.js 🥳

atharmohammad commented 3 years ago

@atharmohammad Hey I am closing this PR in regards to #68

Login was becoming a roadblock for other stuff.

Kudos for your work though. Directly took your Login.js 🥳

Okay,I just couldn't push the changes due to error I was getting due to eslint and prettier after the pull