Closed ADRE9 closed 3 years ago
Make PR against master, and rebase to latest changes of master since it has linting errors being fixed.
I've made the PR to the main now. Can you please check if everything is right? @Abhishek-kumar09
Thanks for your PR. Merging it.
Issue Number
fixes #39
Changes Made 1.I removed the Switch component as ReactSwipeable was doing the same thing either way.
Describe if there is any unusual behavior (Any Warning) of your code(Write
NA
if there isn't) A Warning pops up in yellow as:-Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://reactjs.org/link/unsafe-component-lifecycles for details.
Move data fetching code or side effects to componentDidUpdate.
If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://reactjs.org/link/derived-state
Rename componentWillReceiveProps to UNSAFEcomponentWillReceiveProps to suppress this warning in non-strict mode. In React 18.x, only the UNSAFE name will work. To rename all deprecated lifecycles to their new names, you can run
npx react-codemod rename-unsafe-lifecycles
in your project source folder. Please update the following components: ReactSwipableView[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.