search

codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.
https://educlient.codeforcause.org/
MIT License
130 stars 150 forks source link

Bottom Navigation Design #74

Open symaticvisuals opened 3 years ago

symaticvisuals commented 3 years ago

The Bottom navigation buttons can be updated with a more modern design.

2021-03-13 01 37 55 localhost 89c546d66e16

symaticvisuals commented 3 years ago

@kunal-kushwaha can I work on this?

Abhishek-kumar09 commented 3 years ago

Hi @symaticvisuals Could you please tell us what are the design changes you would like to have.

symaticvisuals commented 3 years ago

Hi @symaticvisuals Could you please tell us what are the design changes you would like to have.

Actually the jcon styles of the navigation using react icons

Abhishek-kumar09 commented 3 years ago

Okay are you gonna dd some svg in place of that? or you want to modify the current styles of the icons

symaticvisuals commented 3 years ago

I want to modify the current styles, I have found the library for that, will be looking to integrate it.

rizwan2000rm commented 3 years ago

@symaticvisuals We already have material-ui icons and I don't think we need react icons.

symaticvisuals commented 3 years ago

Oh ok sure, Actually I was going through the designs so had this suggestion

symaticvisuals commented 3 years ago

Ok, so should I close this issue?

Abhishek-kumar09 commented 3 years ago

@symaticvisuals please let me know what are the other libraries you had thought of, love to hear that.

symaticvisuals commented 3 years ago

@symaticvisuals please let me know what are the other libraries you had thought of, love to hear that.

Sir can I please update you by Saturday, actually am out of station

Abhishek-kumar09 commented 3 years ago

Okay no problem, enjoy buddy!

symaticvisuals commented 3 years ago

@Abhishek-kumar09 Screenshot (565) we can use https://react-icons.github.io/react-icons. Can I work on this?

Abhishek-kumar09 commented 3 years ago

The current icons looks good to me, but if you want to change something you can land with a PR, will see that.

symaticvisuals commented 3 years ago

Ok sure I will do it

Abhijay007 commented 3 years ago

@symaticvisuals the application is on the redesign and as I know, we are making a new design for almost everything so we may need to redesign the bottom nav also. what you can do is to close this issue for now and once the design is completed you can suggest changes in that, if need :)

symaticvisuals commented 3 years ago

@symaticvisuals the application is on the redesign and as I know, we are making a new design for almost everything so we may need to redesign the bottom nav also. what you can do is to close this issue for now and once the design is completed you can suggest changes in that, if need :)

Sure.