codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.
https://educlient.codeforcause.org/
MIT License
130 stars 150 forks source link

Removed errors from development console #91

Closed rizwan2000rm closed 3 years ago

rizwan2000rm commented 3 years ago

Issue Number

fixes #88

Describe the changes you've made

Removed all the development console errors. Turns out most of them were from a single line as a whole component was passed inside a tag which resulted in many errors.

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

Failed prop type: Material-UI: This elevation 4 is not implemented

The error above is caused by soft Shadows in Material UI theming options. I have commented it out for now, as I don't understand what those options means maybe someone can help me with that.

Additional context

There are still 2 errors in the console which are due to some dependencies installed.

[Deprecation] SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021.

Not yet released will be fixed in a react update soon. Issue: https://github.com/facebook/create-react-app/issues/10474 PR: https://github.com/facebook/react/pull/20831

componentWillReceiveProps has been renamed, and is not recommended for use Resolved and published in Alpha PR: https://github.com/oliviertassinari/react-swipeable-views/pull/616

Checklist

rizwan2000rm commented 3 years ago

@Abhishek-kumar09 Please review this PR and also look into soft shadows theming options. I was not able to figure it out. But commenting it out removed the error from the console.

ADRE9 commented 3 years ago

Hey @rizwan2000rm I mean I was also debugging the errors how did you find out the specific location to the errors from the chunk files.

Abhishek-kumar09 commented 3 years ago

Github, rebase

rizwan2000rm commented 3 years ago

@Abhishek-kumar09 I think that didn't work. Do you want me to rebase to a single commit ?

Abhishek-kumar09 commented 3 years ago

I am seeing that you havn't added anything for removing console errors, I could just see the eslint fixes done with npm run lint:fix. I could see many errors in the console. Screenshot from 2021-03-18 13-09-09

rizwan2000rm commented 3 years ago

I'm sorry, I have confirmed with my fork again with latest changes, I don't see any of these errors. I have resolved them. All of those saying "X cannot appear as descendant of p" were due to the following line ` {value === index && (

{children}
  )}`

at line 111, src/pages/CoursePageViewWithVideo/index.js

{value === index && <Box>{children}</Box>} which were resolved just by changing it to this. Typography uses p as a default tag which was wrapped around all those tags, hence resulting in so many errors. All other errors are due to some dependencies installed look above messge for details.

Logs

Abhishek-kumar09 commented 3 years ago

Looks good, Ok to merge once CI passed